Skip to content

Configure Package.swift file to be able to build from source - #53667

Closed
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D81778452
Closed

Configure Package.swift file to be able to build from source#53667
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D81778452

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Summary:
This change updates the Package.swift file to enable building RNTester and HelloWorld from source.

The set of changes is the following:

  • add a BUILD_FROM_SOURCE flag to toggle between building for creating prebuilds and building an app from source
  • configure the proper header search path based on whether we want to build an app from source or not
  • split the ReactFabricComponents target in multiple subtargets. This is required because when building from source we can't have targets whose Source folder is overlapping.

Changelog:

[Internal] -

Differential Revision: D81778452

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@facebook-github-bot

facebook-github-bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

@facebook-github-bot

facebook-github-bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

cortinico
cortinico requested changes Sep 10, 2025
View reviewed changes

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@facebook-github-bot

facebook-github-bot commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81778452

cortinico
cortinico approved these changes Oct 13, 2025
View reviewed changes

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@cipolleschi @facebook-github-bot
Configure Package.swift file to be able to build from source (#53667)
cf89c17 
Summary:

This change updates the Package.swift file to enable building RNTester and HelloWorld from source.

The set of changes is the following:
- add a BUILD_FROM_SOURCE flag to toggle between building for creating prebuilds and building an app from source
- configure the proper header search path based on whether we want to build an app from source or not
- split the ReactFabricComponents target in multiple subtargets. This is required because when building from source we can't have targets whose Source folder is overlapping.

## Changelog:
[Internal] -

Reviewed By: cortinico

Differential Revision: D81778452
@meta-codesync

meta-codesync Bot commented Oct 13, 2025

Copy link
Copy Markdown

@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D81778452.

@meta-codesync meta-codesync Bot closed this in c827474 Oct 13, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 13, 2025
@meta-codesync

meta-codesync Bot commented Oct 13, 2025

Copy link
Copy Markdown

This pull request has been merged in c827474.

@react-native-bot

react-native-bot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in c827474

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cipolleschi @facebook-github-bot @react-native-bot @cortinico